Add workbook data connections to the model#57
Draft
gthb wants to merge 2 commits into
Draft
Conversation
A pivot cache with `sourceType: 'external'` carries a `connectionId` referring to a workbook data connection in `xl/connections.xml`, but the model had no place for the connection itself — so a converter round-tripping such a workbook drops the connection and leaves the cache's `connectionId` dangling. Add a `Connection` type (the `<connection>` core attributes plus `<dbPr>` database properties) and `Workbook.connections`. Covers database/file connections; other source kinds (OLAP, web, text) are left for later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pivot cache with
sourceType: 'external'has aconnectionIdreferring to a workbook data connection inxl/connections.xml. But JSF has no place for the connection itself, so there's nothing for the cache'sconnectionIdto refer to.So add a
Connectiontype (the<connection>core attributes plus<dbPr>database properties) andWorkbook.connections. Covers database/file connections; leave OLAP/web/text source children for later (a connection without one still round-trips its attributes).